wayland-rs icon indicating copy to clipboard operation
wayland-rs copied to clipboard

Failed build when running with coverage on stable Rust

Open tgross35 opened this issue 1 year ago • 2 comments

Both wayland-backend and wayland-client have a line like the following: https://github.com/Smithay/wayland-rs/blob/1fc7814bee5d90f83bab428c8167af43201f8a9b/wayland-backend/src/lib.rs#L46

This is a problem because if building a project with coverage will always try to enable this feature, which will fail if using a stable rustc. This should be changed so the coverage_attribute feature and coverage(...) attributes to go with it are not enabled unless compiled with nightly.

I think the easiest fix is probably to add a Cargo feature gate for nightly features and use it in place of #[cfg_attr(coverage, coverage(...))], as well as updating the spots where the feature is enabled.

tgross35 avatar Apr 26 '24 08:04 tgross35

I would also like to see this implemented.

uglyoldbob avatar Jul 03 '24 16:07 uglyoldbob

Any updates on this?

ToppDev avatar Jan 31 '25 22:01 ToppDev

I've just opened https://github.com/Smithay/wayland-rs/pull/819 to try and fix this.

complexspaces avatar Jun 20 '25 17:06 complexspaces