wayland-rs
wayland-rs copied to clipboard
Generate aliases with "z" stripped for stable dmabuf protocol
As you may know, zwp_linux_dmabuf_v1 became stable without striping of the z prefix.
This is just a random idea to do the striping ourselves, by aliasing all v1 types to zv1 ones.
Eg.
- wp_linux_buffer_params_v1
- WpLinuxBufferParamsV1 -> ZwpLinuxBufferParamsV1
- Event -> Event
- Request -> Request
- ...
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
31bab14) 75.34% compared to head (d230850) 75.62%. Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 75.34% 75.62% +0.28%
==========================================
Files 48 49 +1
Lines 8258 8338 +80
==========================================
+ Hits 6222 6306 +84
+ Misses 2036 2032 -4
| Flag | Coverage Δ | |
|---|---|---|
| main | 58.83% <100.00%> (+0.47%) |
:arrow_up: |
| test-- | 81.41% <100.00%> (+0.32%) |
:arrow_up: |
| test--server_system | 64.96% <100.00%> (+0.45%) |
:arrow_up: |
| test-client_system- | 72.55% <99.08%> (+0.39%) |
:arrow_up: |
| test-client_system-server_system | 55.33% <97.24%> (+0.50%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I fear this would create confusion more than anything else... We'd end up having names that no longer match the rest of the Wayland ecosystem, nor the contents of the debug logs.
It's kind of a strange situation. On the one hand, zwp_linux_dmabuf_v1 is the name of the protocol. On the other hand, it should be named wp_linux_dmabuf_v1 but just isn't for awkward technical reasons.
If we did this, it might be good to mark the old name as #[deprecated]. Rather than just having duplicating in the API.
But overall, it may be best just to leave it as is.