wayland-rs icon indicating copy to clipboard operation
wayland-rs copied to clipboard

client: Add FreezeHandle

Open danieldg opened this issue 2 years ago • 3 comments

This also fixes some potential missed wakeups when using EventQueue methods in a multi-threaded application.

danieldg avatar Jul 27 '22 23:07 danieldg

See https://github.com/danieldg/smithay-client-toolkit/tree/freeze-popup for an example of use.

danieldg avatar Jul 28 '22 00:07 danieldg

Codecov Report

Merging #530 (9fe0936) into master (1f38f9a) will decrease coverage by 0.81%. The diff coverage is 41.02%.

:exclamation: Current head 9fe0936 differs from pull request most recent head 4110177. Consider uploading reports for the commit 4110177 to get more accurate results

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   76.60%   75.79%   -0.82%     
==========================================
  Files          50       50              
  Lines        6938     6986      +48     
==========================================
- Hits         5315     5295      -20     
- Misses       1623     1691      +68     
Flag Coverage Δ
main 61.49% <0.00%> (-0.94%) :arrow_down:
test-- 80.57% <41.02%> (-1.15%) :arrow_down:
test--server_system 63.06% <41.02%> (-0.50%) :arrow_down:
test-client_system- 70.37% <41.02%> (-0.86%) :arrow_down:
test-client_system-server_system 51.80% <41.02%> (-0.60%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wayland-client/src/lib.rs 100.00% <ø> (ø)
wayland-client/src/event_queue.rs 48.40% <31.81%> (-13.70%) :arrow_down:
wayland-client/src/conn.rs 91.66% <91.66%> (+0.92%) :arrow_up:
wayland-backend/src/sys/client_impl/mod.rs 74.04% <0.00%> (-1.13%) :arrow_down:
wayland-backend/src/rs/client_impl/mod.rs 79.73% <0.00%> (-0.57%) :arrow_down:
wayland-backend/src/server_api.rs 69.59% <0.00%> (-0.41%) :arrow_down:
wayland-backend/src/rs/server_impl/client.rs 75.69% <0.00%> (-0.19%) :arrow_down:
wayland-scanner/src/client_gen.rs 99.19% <0.00%> (+<0.01%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 00:07 codecov[bot]

Marked as draft, should rebase on #535 and possibly remove make_early_data depending on the fate of set_data.

danieldg avatar Aug 07 '22 15:08 danieldg

Removed make_early_data, since the primary use for it is no longer necessary due to #531.

danieldg avatar Aug 19 '22 00:08 danieldg

Ok so, coming back to this, I get the need for this I can't think of a better way to achieve it, so I plan to merge it. I believe the only remaining nitpick is about the name of the handle/guard?

elinorbgr avatar Aug 22 '22 09:08 elinorbgr

Thanks!

elinorbgr avatar Aug 25 '22 08:08 elinorbgr