client-toolkit icon indicating copy to clipboard operation
client-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon Smithay

Add `update_keymap` method that's called when server provides keymap

Open ids1024 opened this issue 3 years ago • 1 comments

This is meant to provide a way to address https://github.com/pop-os/xdg-shell-wrapper/issues/8, in combination with https://github.com/Smithay/smithay/pull/750.

This is currently potentially unsound due to the unsafe impl Send for KeyboardData {}. xdg::Keymap uses non-thread-safe ref-counting, but sctk assumes it is only used from one thread. This is difficult to address.

ids1024 avatar Sep 19 '22 19:09 ids1024

The API isn't great here, but I don't know if anything better is really possible. Otherwise this should work fine. (While I think https://github.com/Smithay/smithay/pull/750 isn't quite right.)

ids1024 avatar Oct 06 '22 01:10 ids1024

I don't see anything else that would need to be done, @ids1024 are you fine with this being merged or do you have some new idea to handle this.

i509VCB avatar Nov 07 '22 18:11 i509VCB

Merging it seems good to me, given it's useful to support and I can't really think of a better way to do so.

ids1024 avatar Nov 08 '22 22:11 ids1024