On same deadline, items queued first have priority
When multiple are registered at the same time, those registered first should have priority to make scheduling behavior easier to predict. I don't think this should be added as documented behavior to prevent users from depending on it.
Once nice to have follow up would be to start supporting custom prioritization as tie-breaker so users can define their own to handle tie-breaking. Right now users depend on tweaking expire timestamps to get same effect, which is not clean.
@amcandio Please rebase on master to fix the CI
@notgull rebased!
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.22%. Comparing base (
5ba1370) to head (10465dc).
Additional details and impacted files
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 85.44% 86.22% +0.77%
==========================================
Files 13 15 +2
Lines 1876 2069 +193
==========================================
+ Hits 1603 1784 +181
- Misses 273 285 +12
| Flag | Coverage Δ | |
|---|---|---|
| macos-latest | 85.50% <100.00%> (?) |
|
| ubuntu-latest | 85.82% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@notgull any update on this?
@notgull apologies for the delay! Please let me know if further changes are needed
Hi! Any chance we can ship this one? Not super important but I have this old tech debt item that I could close with this feature!