Smit Lunagariya

Results 102 comments of Smit Lunagariya

Oh, the tests fail because of infinite recursion caused due to: ````c // in main.c double log(double x) { double _lpython_return_variable; _lpython_return_variable = _lfortran_dlog(x); return _lpython_return_variable; } // in lfortran_intrinsics.h...

@rebcabin Can you please review this? Thanks

I can work on implementing `statistics`.

@jstac So simplifying this one: https://python.quantecon.org/markov_asset.html would work? I can work on this if no one else is assigned.

@jstac, This is the new version of #88. The time measures on this PR are: ``` HPI: 0.03126978874206543 VFI: 0.9759271144866943 OPI: 0.3162047863006592 ``` And on the deployed version: https://jax.quantecon.org/opt_savings.html ```...

> Does that also work, or am I wrong? I'm not sure if that would be correct. For the function: ``` B(w, y, w′) = u(Rw + y - w′)...

Hi @jstac, I completed using `vmap` everywhere possible instead of `reshape`. The results on the PR are: ``` HPI completed in 0.03335309028625488 seconds. VFI(jax not in succ) completed in 1.0069973468780518...

Many thanks for the review @jstac. That's a good idea. I'll try to look into that in a new PR so that we can compare this and the new one.

> can you think about a way we might be able to do a pre-commit run to check for long equations? Hmm, this might be a hard one. The main...

Thanks @jstac, @HumphreyYang. I'll also have a look into it at the same time.