django-countries icon indicating copy to clipboard operation
django-countries copied to clipboard

German translation: Update country names

Open raphaelm opened this issue 1 year ago • 3 comments

"Belarus" is today named "Belarus" in German. The name "Weißrussland" is no longer officially used since 2021, including by German authorities. Source: https://de.wikipedia.org/wiki/Belarus#%E2%80%9EWei%C3%9Frussland%E2%80%9C_und_%E2%80%9EBelarus%E2%80%9C

"Französisch-Guinea" has always been a wrong translation of "French Guinea". "Französisch-Guinea" refers to the historic French colony Guinée française which is today the independent state of Guinea. Today's French Guinea, which is a department of the French republic, is called "Französisch-Guayana" in German. Source: https://de.wikipedia.org/wiki/Franz%C3%B6sisch-Guayana

raphaelm avatar Sep 18 '24 12:09 raphaelm

I've made the changes on Transifex now as well, just wanted to provide some reasoning for them

raphaelm avatar Sep 18 '24 12:09 raphaelm

Any change of getting this merged? :)

raphaelm avatar Nov 19 '24 15:11 raphaelm

@SmileyChris Would you happen to have a chance to look at this?

raphaelm avatar Jan 21 '25 13:01 raphaelm

Thank you for the corrections to the German translations!

However, this project manages translations through Transifex. Please submit your translation updates there instead of via pull request.

Translation updates are pulled from Transifex during the release process using just tx-pull.

Closing this PR in favor of the Transifex workflow.

SmileyChris avatar Nov 04 '25 03:11 SmileyChris

I made them on Transifex as well (see above) a year ago but it does not look like they have been pulled: https://app.transifex.com/smileychris/django-countries/translate/#de/djangopo/1274625?q=text%3Abelarus

raphaelm avatar Nov 04 '25 10:11 raphaelm

Thank you @raphaelm for reporting this and for your patience!

Your report helped us discover an underlying bug in our translation workflow. The issue wasn't just that the translations hadn't been pulled—it was that our tx pull command was incorrectly comparing filesystem modification times instead of git commit timestamps, causing it to skip updated translations from Transifex.

I've now:

  1. Fixed the root cause by adding --use-git-timestamps to our Transifex pull commands
  2. Successfully pulled your German translation updates (Belarus → "Belarus", French Guiana → "Französisch-Guayana")
  3. Also pulled updated translations for Afrikaans, Slovak, and Slovenian that were being skipped

This fix is committed and will be included in the next patch release. Thanks again for bringing this to our attention—it's much appreciated!

SmileyChris avatar Nov 11 '25 00:11 SmileyChris

Amazing, thanks! ❤️

raphaelm avatar Nov 11 '25 07:11 raphaelm