magento2-module-store-locator icon indicating copy to clipboard operation
magento2-module-store-locator copied to clipboard

Published 20 hours ago • verified publisher icon Smile-SA

[ADMIN] Can't delete already saved special hours opening

Open pravalitera opened this issue 2 years ago • 2 comments

Preconditions

Magento Version : 2.4.4

Module Store Locator Version : 2.0.0

Environment : Any

Steps to reproduce

  1. Add Special Hours Opening for a retailer and save it 2.Edit the retailer 3.Try to delete the Special Hours

Expected result

  1. Line should be deleted
  2. On save, the Special Hours should be deleted from DB

Actual result

  1. Nothing happens on click, the line is not removed from the DOM

pravalitera avatar Feb 22 '23 09:02 pravalitera

This happens because the JS doesn't find the correct to remove.

image

image

Even if numeric id are authorized for DOM element since HTML5, it seems unvalid. Anyway, it's not very clean to have 0,1,2... as ids.

This issues is fixed in https://github.com/Smile-SA/magento2-module-store-locator/pull/149

pravalitera avatar Feb 22 '23 09:02 pravalitera

@pravalitera This module will supports magento CLI 2.4.4. ??

I installed using composer but getting Below error Screenshot 2023-04-06 at 2 30 03 PM

sanganagouda1 avatar Apr 06 '23 09:04 sanganagouda1