elasticsuite icon indicating copy to clipboard operation
elasticsuite copied to clipboard

Feature #3038 Use display_pattern on product view, product compare pages

Open rbayet opened this issue 1 year ago • 1 comments

(disabled by default)

rbayet avatar Sep 25 '23 15:09 rbayet

Comment copy/pasted from https://github.com/Smile-SA/elasticsuite/pull/3047#issuecomment-1717400647

Hello ~~@ecrocombe~~ @vahonc

Actually, testing the feature locally, I think it needs a bit more polish : the precision is actually not taken into account at all.

It seems that the slider cheats by systematically using the JS price formatter because the locale oriented PHP classes of Magento2 Framework does not seem to really care about it (hence probably because you went for "round"). I've tried using the approach of \Smile\ElasticsuiteCatalog\Model\Layer\Filter\Decimal::formatValue but that does not work either.

~~So I'll try to figure out a way to correctly have the value formatted exactly like in the slider.~~ @vahonc Could you look into it ?

rbayet avatar Sep 25 '23 15:09 rbayet