Nicolas Lebacq
Nicolas Lebacq
> Just my 2 cents; I think that in general most of the above discussions are best suited for discussion on Discord. This is after all, still a draft. However,...
I completely changed my approach when I was told about action priorities. This is something that really needs to be documented and we shouldn't hard code float but always use...
> That was made by purpose. To make loots look like made by real persons. Proposed PR can be make by custom strategy if someone dont like current approach. Personally...
PR was rebased on most recent `master`.
> Whats the effective change between current and new? Previously bots would take often several minutes or time out the roll. Now they roll in about 10-15 seconds.
> Can probably change the title since it is within 10-15 seconds instead of instant like originally setup. Agreed rolling currently takes way too long, it's been a bit for...
> > > Never had problem with that. But maybe other reviewers can comment that subject. > > > > > > Theoretically, a low priority may lead to long...
Just a few observations: - Titles were not removed in TBC. You would keep the highest title you earned. - You should not be able to hold two titles at...
Two new observations: - You likely want to create a way to migrate from `mod-pvp-titles` to this. I have progressed in `mod-pvp-titles` and got all the feat of strength which...
> I'll look at the titles being removed in TBC, that shouldn't happen indeed. There is a config setting for this. IndividualProgression.VanillaPvpTitlesPersistAfterVanilla = 1 with this enabled I do keep...