Compose-Extended-Gestures icon indicating copy to clipboard operation
Compose-Extended-Gestures copied to clipboard

Material 3 upgrade

Open alp-well opened this issue 11 months ago • 4 comments

You are using this lib in other libraries like: Compose-Cropper. Compose-Cropper migrated to Material3 but implements this library. So in dependency tree we can see material2 dependency. If you migrate this lib to M3, Compose-Cropper library will be 1 dependency free.

alp-well avatar Feb 26 '24 16:02 alp-well

Material should not be part of gesture library in the first place. It's only needed in app for using Composables like Text

SmartToolFactory avatar Jun 18 '24 18:06 SmartToolFactory

Oh, then it's better to get rid of the material library directly. Instead of getting rid of m2 and using m3, it's better to get rid of both m2 and m3 at the same time.

alp-well avatar Jun 20 '24 08:06 alp-well

It's only in app for demos, there is no material in gesture module.

SmartToolFactory avatar Jun 20 '24 10:06 SmartToolFactory

So when we implement this library, we will end up downloading all the libraries that are for the demo app as well. Additionally, the libraries that implement this library will also implement the dependencies of the demo app (like compose cropper). This is unnecessary. Is there a chance to configure the library so that it does not implement the demo app's dependencies?

I mean compose-cropper library implements those extra libs because of the demo app:

implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.8.2'
implementation 'androidx.activity:activity-compose:1.9.0'
implementation 'androidx.compose.ui:ui'
implementation "androidx.compose.material:material"

alp-well avatar Jun 20 '24 11:06 alp-well