TokenScript icon indicating copy to clipboard operation
TokenScript copied to clipboard

missing multiple keyrefs constraints

Open SmartLayer opened this issue 3 years ago • 2 comments

  1. contract name keyref is not set up.

SmartLayer avatar Oct 26 '20 05:10 SmartLayer

Below are the list of possible elements where "contract" attribute occurs. Now need to update the schema to check if its respective <ts:contract name="" .../> element should occur in XML.

<ts:ethereum contract="unicon"/>
<ethereum:call function="redeemed" contract="unicon" as="bool">
<ethereum:transaction function="setText" contract="PublicResolver" as="bool">
<ethereum:event type="NameRegistered" contract="ETHRegistrarController" filter="label=${tokenId}" select="name"/>

darakhbharat avatar Oct 26 '20 12:10 darakhbharat

  1. contract name keyref is not set up. This is completed and tested with changes - https://github.com/darakhbharat/TokenScript/commit/38a09be60023b2262f540ec7abad977248cca294

Added ts:contract/@name reference check for above mentioned elements.

We can directly merge this changes to master as these works on schema 1.0 and are independent of XSD 1.1 validation.

darakhbharat avatar Oct 31 '20 15:10 darakhbharat