SmartThingsPublic icon indicating copy to clipboard operation
SmartThingsPublic copied to clipboard

Update aeotec-wallmote.groovy

Open sky-nie opened this issue 2 years ago • 20 comments

We test the device "Minoston Remote Control" and find that the deviceJoinName is not take effect. It is always showed as "Aeotec Wallmote", the DTH name. Another brand is showed, which is not acceptable. So I have to create another DTH and start a new PR(https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/78439). I will cancel the PRs if your guys can fix it soon. Thanks!

sky-nie avatar Jun 28 '22 03:06 sky-nie

@sky-nie that's because You requested to add this device last year:

https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/74138/files and then updated it: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/76125/files

cc: @k-morawski

KKlimczukS avatar Jun 28 '22 07:06 KKlimczukS

@sky-nie that's because You requested to add this device last year:

https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/74138/files and then updated it: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/76125/files

cc: @k-morawski I don't understand your mean- Is this problem caused by the update (the "prod" field can not be used?)?

sky-nie avatar Jun 28 '22 10:06 sky-nie

@sky-nie that's because You requested to add this device last year: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/74138/files and then updated it: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/76125/files cc: @k-morawski I don't understand your mean- Is this problem caused by the update (the "prod" field can not be used?)?

@sky-nie It's not a problem. This device was integrated in that particular DTH last year, that's why it includes that way and it's supported by that DTH: Aeotec Wallmote.

KKlimczukS avatar Jun 28 '22 10:06 KKlimczukS

@sky-nie that's because You requested to add this device last year: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/74138/files and then updated it: https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/76125/files cc: @k-morawski I don't understand your mean- Is this problem caused by the update (the "prod" field can not be used?)?

@sky-nie It's not a problem. This device was integrated in that particular DTH last year, that's why it includes that way and it's supported by that DTH: Aeotec Wallmote. @KKlimczukS: I see, but we find that the deviceJoinName is not take effect in the recently test, it is replaced with the DTH name——it is an unacceptable question. I'm sure that when I first updated the DTH of Aeotec Wallmote, there is not the problem.

sky-nie avatar Jun 30 '22 01:06 sky-nie

@KKlimczukS: I see, but we find that the deviceJoinName is not take effect in the recently test, it is replaced with the DTH name——it is an unacceptable question. I'm sure that when I first updated the DTH of Aeotec Wallmote, there is not the problem.

@sky-nie Can You share any screen of this issue ? (from ST app UI and graphapi)

KKlimczukS avatar Jul 06 '22 08:07 KKlimczukS

Dear @sky-nie, could you please reply to @KKlimczukS request. Please let us know if you have any questions. Thanks

k-morawski avatar Jul 08 '22 09:07 k-morawski

@KKlimczukS: I see, but we find that the deviceJoinName is not take effect in the recently test, it is replaced with the DTH name——it is an unacceptable question. I'm sure that when I first updated the DTH of Aeotec Wallmote, there is not the problem.

@sky-nie Can You share any screen of this issue ? (from ST app UI and graphapi)

Here is the device info:

1657354160734 You can find that the "Name" and "Label" should be "Minoston Remote Control Switch" by the DTH.

And on the phone(from ST app UI and graphapi): 1657354824424

The default deviceName is not "Minoston Remote Control Switch".

@KKlimczukS

sky-nie avatar Jul 09 '22 08:07 sky-nie

@sky-nie Could You double-check following things:

  • remove the device in the ST app
  • enter graphapi and make sure to unpublish all your DTHs that contain Your device's fingerprint (or put that fingerprint in comment and publish DTH) fingerprint mfr: "0312", prod: "0924", model: "D001", deviceJoinName: "Minoston Remote Control", mnmn: "SmartThings", vid: "generic-4-button" //Minoston Wallmote
  • include the device again (device should be backed by production DTH and this moment)
  • check device label again and put screens here

KKlimczukS avatar Jul 11 '22 08:07 KKlimczukS

@sky-nie Could You double-check following things:

  • remove the device in the ST app
  • enter graphapi and make sure to unpublish all your DTHs that contain Your device's fingerprint (or put that fingerprint in comment and publish DTH) fingerprint mfr: "0312", prod: "0924", model: "D001", deviceJoinName: "Minoston Remote Control", mnmn: "SmartThings", vid: "generic-4-button" //Minoston Wallmote
  • include the device again (device should be backed by production DTH and this moment)
  • check device label again and put screens here

I have delete the device from ST app:

Screenshot_20220712-094946_SmartThings

Also there is no normal device listed in the IDE: 1657590696344

And there is only the DTH in the IDE image And I have put that fingerprint in comment:

image

I have published it for myself(Not committed to the repository, so it's highlighted),Now we can see the result:

Screenshot_20220712-100552_SmartThings

The list screenshots: Screenshot_20220712-100600_SmartThings

@KKlimczukS

sky-nie avatar Jul 12 '22 01:07 sky-nie

@sky-nie Please, could You repeat those steps and provide us the timeframe and:

  • location id
  • device id

(You can find both of them in the graph api)

KKlimczukS avatar Jul 20 '22 09:07 KKlimczukS

Please, could You repeat those steps and provide us the timeframe and

@sky-nie Please, could You repeat those steps and provide us the timeframe and:

  • location id
  • device id

(You can find both of them in the graph api)

I'm confused by your needs and I don't get it - Can you provide your email or Samsung account ? I can send an invaitation to you in the test location.

sky-nie avatar Jul 21 '22 07:07 sky-nie

Please, could You repeat those steps and provide us the timeframe and

@sky-nie Please, could You repeat those steps and provide us the timeframe and:

  • location id
  • device id

(You can find both of them in the graph api)

I'm confused by your needs and I don't get it - Can you provide your email or Samsung account ? I can send an invaitation to you in the test location.

@sky-nie When You log in the https://graph.api.smartthings.com You will find all the information that I asked for.

KKlimczukS avatar Jul 21 '22 09:07 KKlimczukS

Please, could You repeat those steps and provide us the timeframe and

@sky-nie Please, could You repeat those steps and provide us the timeframe and:

  • location id
  • device id

(You can find both of them in the graph api)

I'm confused by your needs and I don't get it - Can you provide your email or Samsung account ? I can send an invaitation to you in the test location.

@sky-nie When You log in the https://graph.api.smartthings.com You will find all the information that I asked for.

Oh, I find that it is defferent with the IDE I used:

1658457715139

And the screenshot you refered url: 1658457797943

Am I using it wrong?

sky-nie avatar Jul 22 '22 02:07 sky-nie

@sky-nie

  1. After You re-onboard Your device and note the time-frame, please:
  2. enter graphapi, go to locations and select that location that Your device is included to. The location id should be in the URL(... /location/show/
  3. then go to devices and select device You added. Again, device id should be in the URL (.../device/show/

KKlimczukS avatar Jul 22 '22 06:07 KKlimczukS

For the device "Aeotec Wallmote" showed as above: https://graph-na04-useast2.api.smartthings.com/device/show/6b3e64a7-a358-46d9-a52b-28581a7f0221

The location "nie": https://graph-na04-useast2.api.smartthings.com/location/show/6832deb1-2d9f-4508-8a99-d7715987ad22

sky-nie avatar Jul 22 '22 06:07 sky-nie

@sky-nie Any timeframe ? (when did You onboard that device ?)

KKlimczukS avatar Jul 22 '22 07:07 KKlimczukS

@sky-nie Any timeframe ? (when did You onboard that device ?)

I delete the device ,and repeat to onboard that device: The location "nie" keeep as "6832deb1-2d9f-4508-8a99-d7715987ad22". And the device id keep a static string every time---not same with last time.

sky-nie avatar Jul 23 '22 01:07 sky-nie

@sky-nie ok, when exactly did it happen ? (YYYY-MM-DD HH:MM:SS)

KKlimczukS avatar Jul 25 '22 06:07 KKlimczukS

@sky-nie ok, when exactly did it happen ? (YYYY-MM-DD HH:MM:SS) For this product, the problem is static exist.

sky-nie avatar Jul 29 '22 08:07 sky-nie

@sky-nie Investigation is ongoing. Please, could You re-join the device again and post a current device id ? cc: @k-morawski

KKlimczukS avatar Aug 10 '22 10:08 KKlimczukS

@sky-nie Investigation is ongoing. Please, could You re-join the device again and post a current device id ? cc: @k-morawski

@sky-nie cc: @k-morawski

KKlimczukS avatar Aug 22 '22 08:08 KKlimczukS

Closed due to long inactivity.

KKlimczukS avatar Aug 26 '22 10:08 KKlimczukS