Matter Switch: Support Fan/Light device
Type of Change
- [ ] WWST Certification Request
- If this is your first time contributing code:
- [ ] I have reviewed the README.md file
- [ ] I have reviewed the CODE_OF_CONDUCT.md file
- [ ] I have signed the CLA
- [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
- If this is your first time contributing code:
- [ ] Bug fix
- [x] New feature
- [ ] Refactor
Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code in hard-to-understand areas
- [ ] I have verified my changes by testing with a device or have communicated a plan for testing
- [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior
Description of Change
This change adds a new profile for a fan+color light device, brings in handlers for fan attributes and capabilities, and adds new logic to select the new profile and create the component map.
Summary of Completed Tests
Will be tested with an Orein fan.
Channel deleted.
Test Results
66 files 422 suites 0s ⏱️ 2 171 tests 2 171 ✅ 0 💤 0 ❌ 3 694 runs 3 694 ✅ 0 💤 0 ❌
Results for commit aa7c504d.
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 92% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua | 93% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua | 96% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua | 38% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua | 91% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against aa7c504d6bb72b2f9bcf160306eff9d10db1ab2e
Can you do an onboarding test of a light-button device as well? Also, one with a multi-button device? Just trying to hit all the affected paths. We should also test a parent-child switch device since the handling for their creation was moved.
Duplicate profile check: Passed - no duplicate profiles detected.