SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Adding support for frient Intelligent Smoke Alarm (SMSZB-120)

Open GAFfrient opened this issue 9 months ago • 7 comments

Check all that apply

Type of Change

  • [x] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [x] I have signed the CLA
    • [x] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [x] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [x] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

GAFfrient avatar Mar 26 '25 07:03 GAFfrient

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 26 '25 07:03 CLAassistant

Hey @GAFfrient. We will begin a review of this PR.

When you have a free moment, please sign the required Contributors License Agreement https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/2024#issuecomment-2753421214

lelandblue avatar Mar 27 '25 13:03 lelandblue

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Mar 27 '25 13:03 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Mar 27 '25 13:03 github-actions[bot]

Test Results

   66 files  ±0    425 suites  ±0   0s ⏱️ ±0s 2 182 tests +7  2 182 ✅ +7  0 💤 ±0  0 ❌ ±0  3 717 runs  +9  3 717 ✅ +9  0 💤 ±0  0 ❌ ±0 

Results for commit ad30fb63. ± Comparison against base commit d773c031.

This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both.
On changing the operatinalState to STOPPED, robotCleanerOperatingState must be set to the appropriate value
Clear alarm and smokeDetector states, and read firmware version when the device is added
Should detect newer firmware version and use correct endian format to turn off the siren
Should detect newer firmware version and use correct endian format to turn on the siren
Should detect older firmware version and use correct endian format to turn on the siren
Test firmware version conversion using direct simulation
ZoneStatusChangeNotification should be handled: tested
infochanged to check for necessary preferences settings: tempSensitivity, warningDuration
init and doConfigure lifecycles should be handled properly

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 27 '25 13:03 github-actions[bot]

File Coverage
All files 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 87% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara-gas/init.lua 94% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against ad30fb63027781075b669ddc1899804d8e5363d8

github-actions[bot] avatar Mar 27 '25 13:03 github-actions[bot]

Hey @GAFfrient. We will begin a review of this PR.

When you have a free moment, please sign the required Contributors License Agreement #2024 (comment)

Hello.

Now I did :)

GAFfrient avatar Mar 28 '25 06:03 GAFfrient

We'd like to see some tests covering the new behavior.

Unit tests added in the latest commit.

GAFfrient avatar Apr 11 '25 06:04 GAFfrient