SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add ElectricalMeasurement cluster configuration

Open kdbang opened this issue 11 months ago • 4 comments

Add ElectricalMeasurement cluster configuration

  • ACPowerDivisor
  • ACPowerMultiplier
local active_power_ac_power_multiplier_configuration = {
  cluster = zcl_clusters.ElectricalMeasurement.ID,
  attribute = zcl_clusters.ElectricalMeasurement.attributes.ACPowerMultiplier.ID,
  minimum_interval = 1,
  maximum_interval = 43200,
  data_type = zcl_clusters.ElectricalMeasurement.attributes.ACPowerMultiplier.base_type,
  reportable_change = 1
}

local instantaneous_demand_configuration = {
  cluster = zcl_clusters.SimpleMetering.ID,
  attribute = zcl_clusters.SimpleMetering.attributes.InstantaneousDemand.ID,
  minimum_interval = 1,
  maximum_interval = 3600,
  data_type = zcl_clusters.SimpleMetering.attributes.InstantaneousDemand.base_type,
  reportable_change = 5
}

refer to https://smartthings.atlassian.net/browse/CHAD-14701 https://github.ecodesamsung.com/iot-hub/scripting-engine/pull/1755

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [x] New feature
  • [ ] Refactor

Checklist

  • [x] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

kdbang avatar Jan 16 '25 02:01 kdbang

Test Results

   66 files    420 suites   0s ⏱️ 2 164 tests 2 164 ✅ 0 💤 0 ❌ 3 685 runs  3 685 ✅ 0 💤 0 ❌

Results for commit c0111b4f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jan 16 '25 02:01 github-actions[bot]

zigbee-power-meter_coverage.xml

File Coverage
All files 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua 96% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 76% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97% :white_check_mark:

zigbee-switch_coverage.xml

File Coverage
All files 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua 96% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 76% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/wallhero/init.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/ge-link-bulb/init.lua 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/enbrighten-metering-dimmer/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 93% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/init.lua 73% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/vimar/init.lua 70% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/laisiao/init.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/multi-switch/init.lua 87% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/tuya-multi/init.lua 43% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 37% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/jasco/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/aurora-relay/init.lua 80% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 95% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against c0111b4f82022f36ac718a89a4b6180af41d1816

github-actions[bot] avatar Jan 16 '25 02:01 github-actions[bot]

Hi @kdbang, it looks like this change was needed to get some tests passing in the scripting-engine repo driver tests. Just checking if we were still planning on getting this in?

NoahCornell avatar Jan 28 '25 19:01 NoahCornell

Hi @kdbang, it looks like this change was needed to get some tests passing in the scripting-engine repo driver tests. Just checking if we were still planning on getting this in?

@NoahCornell yes, I think this PR needs to be merged with below PR. https://github.ecodesamsung.com/iot-hub/scripting-engine/pull/1755

I think we should deploy zigbee-switch and zigbe-power-merter edge driver with 0.56 hub core. I am not sure when we can deploy the edge drivers.

kdbang avatar Jan 31 '25 02:01 kdbang

Channel deleted.

github-actions[bot] avatar Apr 03 '25 19:04 github-actions[bot]