SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

add maileke air quality detector

Open thinkaName opened this issue 11 months ago • 6 comments

Check all that apply

Type of Change

  • [x] WWST Certification Request
    • If this is your first time contributing code:
      • [x] I have reviewed the README.md file
      • [x] I have reviewed the CODE_OF_CONDUCT.md file
      • [x] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [x] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

thinkaName avatar Jan 03 '25 06:01 thinkaName

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Jan 03 '25 06:01 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Jan 03 '25 06:01 github-actions[bot]

Test Results

   67 files    424 suites   0s ⏱️ 2 182 tests 2 182 ✅ 0 💤 0 ❌ 3 710 runs  3 710 ✅ 0 💤 0 ❌

Results for commit 3f826bd9.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jan 03 '25 06:01 github-actions[bot]

File Coverage
All files 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-air-quality-detector/src/MultiIR/init.lua 86% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3f826bd9b0de163af47d3c835b9ff35ad553b5c0

github-actions[bot] avatar Jan 03 '25 06:01 github-actions[bot]

Here's an example of a driver with custom clusters:

https://github.com/ldeora/SmartThingsEdgeDrivers/tree/main/IKEA-VINDSTYRKA-TVOC

You can see how you can configure them (the laziest way), some naming conventions, how you can change the device tile and much more.

This is a very friendly and helpful community where you can discuss these things before you submit a pull request:

https://community.smartthings.com/c/developer-programs/85

ldeora avatar Jan 03 '25 21:01 ldeora

Hello, @greens, @cbaumler, @wkhenon the partner has updated their PR, plz review.

FrankSpringfield avatar Mar 03 '25 10:03 FrankSpringfield