SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

fix-an-issue-of-window-covering-status-inconsistency

Open pInksenberg opened this issue 1 year ago • 4 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [x] Bug fixx
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The previous matter-window-covering edge driver use CurrentPositionLiftPercent100ths and OperationalStatus to decide window covering status (opening/open/closing/closed/partially open). However, sometimes operational status event comes first and sometimes position event comes first, makes the code logic complex. To simplify the code, TargetPositionLiftPercent100ths and CurrentPositionLiftPercent100ths are now used to decide the status of window covering without considering which attribute event comes first.

Summary of Completed Tests

pInksenberg avatar Oct 11 '24 11:10 pInksenberg

Invitation URL: https://bestow-regional.api.smartthings.com/invite/6Vjdnbw5Nv2N

github-actions[bot] avatar Oct 11 '24 11:10 github-actions[bot]

Test Results

   63 files    396 suites   0s :stopwatch: 1 937 tests 1 914 :white_check_mark: 0 :zzz: 23 :x: 3 361 runs  3 338 :white_check_mark: 0 :zzz: 23 :x:

For more details on these failures, see this check.

Results for commit 447740d3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 11 '24 11:10 github-actions[bot]

File Coverage
All files 51% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 51% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 447740d35102bfcb323773e2c028f9f0df87fb3f

github-actions[bot] avatar Oct 11 '24 11:10 github-actions[bot]

Hello @pInksenberg - I am assuming due to inactivity that this PR can be closed. Could you please confirm?

lelandblue avatar Jan 09 '25 16:01 lelandblue