SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Update doConfigure for RVC

Open HunsupJung opened this issue 1 year ago • 4 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [x] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

There's an issue that Dreame RVC is not working. In detail, Dreame RVC has mandatory clusters RVC RunMode, RVC Operational state cluster but doesn't have RunCleanMode cluster. so we need to map the appropriate profile accoding to the cluster list supported by each device.

https://smartthings.atlassian.net/browse/IOTE-4435

Summary of Completed Tests

HunsupJung avatar Sep 10 '24 07:09 HunsupJung

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Sep 10 '24 07:09 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Sep 10 '24 07:09 github-actions[bot]

Test Results

   62 files    384 suites   0s :stopwatch: 1 864 tests 1 864 :white_check_mark: 0 :zzz: 0 :x: 3 267 runs  3 267 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 06b6ba92.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 10 '24 07:09 github-actions[bot]

File Coverage
All files 24% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 24% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 06b6ba92dcbacd558fe14ec8bbfe8bf6b7a64254

github-actions[bot] avatar Sep 10 '24 07:09 github-actions[bot]

replace with https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1803

HunsupJung avatar Mar 13 '25 10:03 HunsupJung