SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add new-matter-lock driver

Open HunsupJung opened this issue 1 year ago • 4 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [x] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

HunsupJung avatar Sep 09 '24 15:09 HunsupJung

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Sep 09 '24 15:09 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Sep 09 '24 15:09 github-actions[bot]

Test Results

   64 files    397 suites   0s :stopwatch: 1 974 tests 1 974 :white_check_mark: 0 :zzz: 0 :x: 3 409 runs  3 409 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 37709e80.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 09 '24 15:09 github-actions[bot]

File Coverage
All files 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 37709e807e3112146180af997d88615e5c8f90b3

github-actions[bot] avatar Sep 09 '24 15:09 github-actions[bot]

@lelandblue @ctowns I would like to merge this patch before the next release. I hope you can help me to meet the schedule.

HunsupJung avatar Oct 04 '24 09:10 HunsupJung

@HunsupJung could you add more unit tests for the new-matter-lock driver? Currently the code coverage for this driver is very low, so we should add additional test cases to increase the code coverage. You should be able to copy the test cases from the test_matter_lock_cota.lua and test_matter_lock_codes.lua files as a example, and make the necessary changes to account for the new capabilities (such as using lockAlarm instead of tamperAlert, and including the new capabilities such as `lockCredentials'). The structure should be similar to what is done in the other test files, but you will need to swap in the new capabilities. If you need additional help with this, please let me know and I can help!

ctowns avatar Oct 09 '24 21:10 ctowns

@ctowns Okay, I will update unit test for new door lock driver tomorrow.

HunsupJung avatar Oct 10 '24 13:10 HunsupJung

@lelandblue I think I added the testing you requested that's blocking the merge. Was there anything else you needed for this?

hcarter-775 avatar Oct 11 '24 19:10 hcarter-775

Thank you for writing the new unit tests @HunsupJung ! I think this looks like it is ready to go.

One last thing - were you able to run the regression tests listed here with the new code changes? I know you have been doing a lot of testing over the past few days, so I think many of these cases have been covered but I just want to make sure the testing is good to go.

Otherwise, I think this PR is ready to go. Thank you for your hard work on this 💪 !

ctowns avatar Oct 18 '24 02:10 ctowns

@ctowns Thank you for checking. I updated the regression tests here. It's all thanks to the help of you and the US team.

HunsupJung avatar Oct 18 '24 13:10 HunsupJung