SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Matter Sensor: Streamline do_configure function in air quality sensor subdriver

Open hcarter-775 opened this issue 1 year ago • 3 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

hcarter-775 avatar Aug 21 '24 22:08 hcarter-775

Channel deleted.

github-actions[bot] avatar Aug 21 '24 22:08 github-actions[bot]

Test Results

   63 files    396 suites   0s :stopwatch: 1 937 tests 1 937 :white_check_mark: 0 :zzz: 0 :x: 3 361 runs  3 361 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3f32d987.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 21 '24 22:08 github-actions[bot]

File Coverage
All files 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3f32d9870692f4d359cfc1435df2dd4bb92e082e

github-actions[bot] avatar Aug 21 '24 22:08 github-actions[bot]