SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

fix an issue of fan proposed capabilities

Open pInksenberg opened this issue 1 year ago • 7 comments

Description: During the WWST for the Yeelight fan (a bridged device), we discovered that after onboarding the devices by sharing through yeelight App, it displays an unsupported capability called "windMode."

The reason is that the "fan.yml" profile is chosen for the bridged device (fan device type) when it is shared via Matter, and the windMode capability is included by default in this profile. However, certain fan device types do not support windMode because the WindSetting (0x000A) is not a mandatory attribute, which means that the command to write the WindSetting cannot be sent.

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [x] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [x] I have performed a self-review of my code
  • [x] I have commented my code in hard-to-understand areas
  • [x] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

pInksenberg avatar Aug 21 '24 03:08 pInksenberg

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Aug 21 '24 03:08 github-actions[bot]

Invitation URL: https://bestow-regional.api.smartthings.com/invite/8zM7y1yEvXlp

github-actions[bot] avatar Aug 21 '24 03:08 github-actions[bot]

Test Results

   61 files    375 suites   0s :stopwatch: 1 823 tests 1 787 :white_check_mark: 0 :zzz: 0 :x: 36 :fire: 3 171 runs  3 108 :white_check_mark: 0 :zzz: 0 :x: 63 :fire:

For more details on these errors, see this check.

Results for commit bea6d14f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 21 '24 03:08 github-actions[bot]

File Coverage
All files 58% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 59% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against bea6d14f01d0e0801570e92b89afcdd8977e612d

github-actions[bot] avatar Aug 21 '24 03:08 github-actions[bot]

Hello, the problems mentioned in this PR are being handled in a wider scale in this PR here. Unfortunately, the metadata used in the original fan profile cannot be used for the proposed new profiles, and this work to create new metadata can be tracked here. These changes will go live as soon as the metadata is released in production OR when the new fanMode capability is released to production at the end of R3, whichever happens first. If you have any questions, feel free to reach out! Thank you

hcarter-775 avatar Aug 21 '24 16:08 hcarter-775

@hcarter-775 I have assigned https://smartthings.atlassian.net/jira/software/c/projects/MTR/issues/MTR-778 to you, please notify us when this is ready and we will test here.

wangjinliang12345 avatar Aug 22 '24 11:08 wangjinliang12345

Hello @wangjinliang12345 , the fixes to this should now be in production. Please re-test at your convenience!

hcarter-775 avatar Sep 12 '24 15:09 hcarter-775