SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Matter Water Sensor Device Integration

Open hcarter-775 opened this issue 1 year ago • 3 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [x] I have reviewed the README.md file
      • [x] I have reviewed the CODE_OF_CONDUCT.md file
      • [x] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [X] New feature
  • [ ] Refactor

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR includes protoype support for:

  • Water Leak Detector
  • Water Freeze Detector
  • Rain Sensor

Summary of Completed Tests

N/A

hcarter-775 avatar Jul 18 '24 18:07 hcarter-775

Channel deleted.

github-actions[bot] avatar Jul 18 '24 18:07 github-actions[bot]

Test Results

   61 files  ±0    379 suites  +2   0s :stopwatch: ±0s 1 817 tests +2  1 753 :white_check_mark:  - 22  0 :zzz: ±0  0 :x: ±0  64 :fire: +24  3 167 runs  +3  3 072 :white_check_mark:  - 31  0 :zzz: ±0  0 :x: ±0  95 :fire: +34 

For more details on these errors, see this check.

Results for commit 9be8e5d0. ± Comparison against base commit 74630ed0.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
Test profile change on init for Room AC device type
Boolean state freeze detection reports should generate correct messages
Boolean state leak detection reports should generate correct messages
Test profile change on init for Freeze and Leak combined device type

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 18 '24 18:07 github-actions[bot]

File Coverage
All files 40% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 10% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/server/attributes/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/server/attributes/SensorFault.lua 78% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/SensorFaultBitmap.lua 76% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/Feature.lua 55% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/init.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/init.lua 75% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 9be8e5d03fdd20a83d8716bddcdeb87563b7f4aa

github-actions[bot] avatar Jul 18 '24 18:07 github-actions[bot]

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Aug 09 '24 20:08 github-actions[bot]