CHAD-13561: Add support for FanControl's Rocking feature
Description:
-
Functionality has been added to matter thermostat to support FanControl's Rock feature using the fanOscillationMode capability.
-
Further, a series of new profiles were built to support this feature. They are the same as previously made air purifier profiles, with the addition of the rocking capability.
-
Implementation is almost identical to what was built for FanControl's Wind feature support.
Testing:
- A new series of test cases were built for this feature, following the wind mode tests structure.
- More, tested with a Fan device that supports rocking and the updates were tested successfully on-device.
Duplicate profile check: Passed - no duplicate profiles detected.
Test Results
61 files ±0 380 suites ±0 0s :stopwatch: ±0s 1 828 tests ±0 1 754 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 74 :fire: ±0 3 180 runs +1 3 073 :white_check_mark: +1 0 :zzz: ±0 0 :x: ±0 107 :fire: ±0
For more details on these errors, see this check.
Results for commit d23d9f1a. ± Comparison against base commit 43f97fd4.
This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Test profile change on init for Room AC device type
Test rock mode
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 80% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua | 83% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua | 42% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against d23d9f1a2ea65309f4d843c40666b3c674fed647