SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Include embedded config for profiles using temperatureAlarm

Open hcarter-775 opened this issue 1 year ago • 4 comments

The temperatureAlarm capability supports four enum values: freeze, cleared, heat, and rateOfRise. Currently, all driver profiles that support this capability exclude rateOfRise since it is unused and will come up in automations if not excluded, and it is the same case for these dishwasher profiles. Since this enum is not used in the dishwasher subdriver, it should be excluded just as is done in other driver profiles.

hcarter-775 avatar Jul 10 '24 16:07 hcarter-775

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

Test Results

   60 files  ±0    377 suites  ±0   0s :stopwatch: ±0s 1 821 tests ±0  1 821 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  3 159 runs  ±0  3 159 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1b493b98. ± Comparison against base commit c936387a.

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 1b493b980263c2d09abe81baedb1a0381dda044f

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

@hcarter-775 Not urgent, just wanted to check in. Is this PR still needed? I dont see open work for it. Please close if this scope has changed.

lelandblue avatar Oct 11 '24 13:10 lelandblue

Closing due to being incompatible with this PR per the testing of @HunsupJung

hcarter-775 avatar Oct 11 '24 19:10 hcarter-775