SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

adding maestro thermostat SMT402AD model

Open gcavalcantistelpro opened this issue 1 year ago • 4 comments

Replacing the stelpro maestro thermostat model to SMT402AD

gcavalcantistelpro avatar Jul 04 '24 19:07 gcavalcantistelpro

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 04 '24 19:07 CLAassistant

Test Results

   64 files    401 suites   0s ⏱️ 2 001 tests 2 001 ✅ 0 💤 0 ❌ 3 441 runs  3 441 ✅ 0 💤 0 ❌

Results for commit 0b91eab1.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 16 '24 14:07 github-actions[bot]

File Coverage
All files 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 78% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 89% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/aqara/init.lua 78% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua 89% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 97% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 0b91eab14b0fc1fff86c56662a553bdf39d87225

github-actions[bot] avatar Jul 16 '24 14:07 github-actions[bot]

Invitation URL: https://bestow-regional.api.smartthings.com/invite/VbMbXYJeG8lB

github-actions[bot] avatar Jul 16 '24 19:07 github-actions[bot]

Hey @Brianj94 and @gcavalcantistelpro . Lets go the safe route here.

Could we leave the existing code in, and just only add new code? For example, lets add a whole fringerprint for the SMT402AD device and add lines in the subdriver for that device verses removing anything that is existing.

Please review and adjust, and thank you!

lelandblue avatar Nov 15 '24 19:11 lelandblue