SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add device configuration for supporting Routine

Open HunsupJung opened this issue 1 year ago • 7 comments

In the case of mode capability, presentation is implemented in the list display type. Therefore, device configuration was added to support automation in the device type that supports the mode capability.

HunsupJung avatar Jun 19 '24 11:06 HunsupJung

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

Test Results

   60 files  ±0    375 suites  ±0   0s :stopwatch: ±0s 1 820 tests ±0  1 820 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  3 168 runs  ±0  3 168 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit c98cd6f6. ± Comparison against base commit c18a6de6.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

File Coverage
All files 24% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 24% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against c98cd6f6c922b6ae2f1546a3fd8db1545c72bdea

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

Is metadata the only way we can support supportedArguments for now? Longterm, could we modify the plugin to utilize the supportedArguments value for R3 so we do not need custom metadata? I think this is okay but in general I think we try to avoid using metadata with custom presentations.

ctowns avatar Jul 01 '24 03:07 ctowns

Yes, the metadata is the only way to support supportedArguments for now. I will ask Plugin team to apply supportedArguments to mode capability. (Actually, It also needs to apply dynamic list to mode capability). But I'm not sure how long does it take that Plugin team applies my request.

I think this is okay but in general I think we try to avoid using metadata with custom presentations.

I agree with you

HunsupJung avatar Jul 01 '24 03:07 HunsupJung

@ctowns The list stored in supportedArguments must be available for selection in the Detail view and the list stored in supportedModes must be available for selection in Routine (Automation).

Additionally, The presentation team is preparing patches that the setting that only can be set in device configuration can be set in embedded configuration. so This patch will be used temporarily and replaced with it when new patch are added.

HunsupJung avatar Jul 29 '24 09:07 HunsupJung