SmartThingsEdgeDrivers changed profile name in motion.yml

Jun 13 '24 07:06 pInksenberg

All committers have signed the CLA.

Jun 13 '24 07:06 CLAassistant

In device init lifecycle. A Matter Sensor will check and update its capabilities by running check_for_battery in init.lua. Then, device:try_update_metadata({profile = profile_name}) will be executed.

However, since there is no profile named "motion", even though the profile name in motion.yml is "matter-motion", the execution of device:try_update_metadata({profile = profile_name}) will fail.

Jun 13 '24 07:06 pInksenberg

hello @greens , can you help us with verification?

Jun 18 '24 02:06 pInksenberg

hello @ctowns , cloud you plz help to review?

Aug 16 '24 04:08 pInksenberg

Hello @pInksenberg! Before we make this change, we must confirm that the profile with the name matter-motion is not currently being used by devices, or else changing the name could result in some devices losing their profile presentation.

@hcarter-775 is working on a similar change to clean up the profile names here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1466

I believe he has confirmed we can safely make this change, so we will incorporate this as a part of #1466

Aug 16 '24 18:08 ctowns

This PR, mentioned above by @ctowns, handles the issue in this PR and has finally been merged to main. Therefore, this PR can safely be closed.

Aug 20 '24 20:08 hcarter-775