SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

update aeotec smart switch 7 for ST energy

Open iot-holding opened this issue 1 year ago • 7 comments

iot-holding avatar Jun 11 '24 12:06 iot-holding

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Jun 11 '24 17:06 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Jun 11 '24 17:06 github-actions[bot]

Test Results

   64 files    402 suites   0s ⏱️ 1 999 tests 1 999 ✅ 0 💤 0 ❌ 3 450 runs  3 450 ✅ 0 💤 0 ❌

Results for commit 38545bfc.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 11 '24 17:06 github-actions[bot]

File Coverage
All files 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/preferences.lua 99% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/configurations.lua 99% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/multi-metering-switch/init.lua 93% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/fibaro-wall-plug-us/init.lua 96% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli-LED/init.lua 93% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/zwave-dual-switch/init.lua 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/zooz-power-strip/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/qubino-flush-1d-relay/init.lua 83% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/aeotec-heavy-duty/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/aeotec-smart-switch/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/init.lua 85% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli-2-channel-smart-plug/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/eaton-5-scene-keypad/init.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/init.lua 84% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/qubino-flush-2-relay/init.lua 97% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 38545bfc22241d93bfd3c15f16912167ed8565e4

github-actions[bot] avatar Jun 11 '24 17:06 github-actions[bot]

Please include some tests of the new functionality.

And I think this should be moved to a sub-driver of the existing smart switch driver, rather than being added at the top level. That way it can simply inherit the on/off behavior without redefining it.

greens avatar Jun 11 '24 17:06 greens

Checking drivers/SmartThings/zwave-switch/src/aeotec-smart-switch/init.lua 1 error

    drivers/SmartThings/zwave-switch/src/aeotec-smart-switch/init.lua:34:3: (E011) expected '}' (to close '{' on line 32) near '{'

greens avatar Jul 16 '24 18:07 greens

HI @greens , Are there any additional changes needed from Aeotec for this PR?

Brianj94 avatar Sep 12 '24 13:09 Brianj94

Hey @iot-holding When you have a free moment could you please sign our CLA?

lelandblue avatar Mar 24 '25 19:03 lelandblue

@lelandblue I signed the CLA just now.

iot-holding avatar Mar 26 '25 12:03 iot-holding