contracts icon indicating copy to clipboard operation
contracts copied to clipboard

Fix short address decoding (develop branch)

Open k06a opened this issue 6 years ago • 2 comments

Example addresses:

0x0014F55A50b281EFD12294f0Cda821Bd8171e920
0x0000000000000000000000000000000000000000

k06a avatar Oct 27 '18 21:10 k06a

Hi, thanks for changing the branch. But still, can you explain why this change is needed? why should we support addresses longer than 20 bytes?

yaronvel avatar Oct 28 '18 13:10 yaronvel

@yaronvel no, you should support addresses shorter than 20 bytes, because it could contain first zero bytes for the probability reasons.

Encoders could encode addresses as numbers and use for example 19 or 18 bytes for some addresses, this is an absolutely valid case for abstract RLP encoder.

k06a avatar Oct 28 '18 18:10 k06a