SmartPack-Kernel-Manager icon indicating copy to clipboard operation
SmartPack-Kernel-Manager copied to clipboard

Wrong TCP congestion algo shown on 865 devices when changed

Open mrslezak opened this issue 4 years ago • 5 comments

Not sure why, SmartPack will once a TCP algo is changed say from Reno (default on 865) to BBR, the algo field will go right back to Reno. Although the command: sysctl net.ipv4.tcp_congestion_control from a root terminal will show that Reno is NOT the correct TCP algo, in this case it's updated to BBR. I imagine the fix is just changing where the value is read from. Note FK Kernel manager has this issue too, only EXKM shows correctly what sysctl shows.

mrslezak avatar Aug 01 '20 01:08 mrslezak

This little script shows the real value I don't know where the name is pulled in from the UI but feel free to use it I just added under Scripts Manager:

#!/system/bin/sh sysctl net.ipv4.tcp_congestion_control;

mrslezak avatar Aug 02 '20 22:08 mrslezak

And believe it or not, it's just a display issue in the UI. I can select a different TCP algo (despite always saying Reno), Apply at Boot, and it selects the proper one chosen in the drop down menu. So I don't imagine this will be a hard fix for you guys.

mrslezak avatar Aug 02 '20 23:08 mrslezak

@mrslezak I am really sorry for the delayed response as I'm (still) busy with personal things. I'll try to fix it in future. Have a nice day...

sunilpaulmathew avatar Aug 03 '20 08:08 sunilpaulmathew

It's not a huge deal since it actually works under the scenes just a UI display issue.

mrslezak avatar Aug 03 '20 14:08 mrslezak

sysctl -n net.ipv4.tcp_congestion_control;

That just displays the algo name I imagine the code under the field for TCP algorithm under Misc could just pull that value on load and when changed. When you have time of course.

mrslezak avatar Aug 08 '20 17:08 mrslezak