PackageManager icon indicating copy to clipboard operation
PackageManager copied to clipboard

Use getVersionName instead getVersionCode for apk exports

Open balporig opened this issue 2 years ago • 4 comments

The implementation of #76 uses sAPKUtils.getVersionCode to prevent overwrites which for that purpose works fine, but as in most time it does not correspond to the actual app version it's not very useful. My suggestion is to use the human-readable sAPKUtils.getVersionName instead, just as for the Export Details and App Info. Here's an example app Elevate with version 5.60.1:

app version
com.wonder.apkm no version
com.wonder_2450.apkm getVersionCode
com.wonder_5.60.1.apkm getVersionName

balporig avatar May 08 '22 09:05 balporig

@balporig I understand & I'll think about it. Actually, version code (not version name) is the only thing supposed to change on every app update.

sunilpaulmathew avatar May 08 '22 19:05 sunilpaulmathew

Yep, you're right, but usually only the version name is exposed to end users

balporig avatar May 09 '22 11:05 balporig

Or would it be possible to leave the choice of naming rules in the parameters ? I would like to be able to name my exported APKs as "Package Manager-com.smartpack.packagemanager-v6.8-68.apk" instead of "Package Manager_68.apk".

Just-Regis avatar Apr 27 '23 22:04 Just-Regis

Should have used #95 Solution

Pantyhose-X avatar Feb 15 '24 03:02 Pantyhose-X