Faulty behavior when the device is rooted but root access is denied

[SebiderSushi]

Android version 11 (LineageOS 18.1) Root method: Magisk version 26.1 Package Manager version: 7.0 (70) from F-Droid

Issue description

Some features that work on a non-rooted device do not work on a rooted device if root access for Package Manager is denied. I noticed it with batch uninstallation of apps at least. I did not test any other feature that might be affected.

Steps to reproduce

1. Root the device
2. Install Package Manager
3. Deny root access when asked
4. Select multiple applications
5. Choose action "Uninstall"

Expected behavior

Package Manager detects that root access was denied and falls back to uninstalling each app one by one via the system dialog.

Observed behavior

Package Manager opens a batch uninstall activity and appears to try and uninstall the apps via root access which obviously fails.

Suggested solution

Detect if root access was denied and perform each action as if the device was not rooted at all.

Possible alternatives

• Grant root access to Package Manager Batch uninstallation is the only feature i'm using which is affected by root access. I don't use it very much so when i do, i am fine with clicking the system uninstall dialog a couple of times. I try to grant root access to as few apps as possible and i'd prefer to not grant root access just for this one feature.