Weiwu Zhang

Results 124 comments of Weiwu Zhang
trafficstars

Quote @JamesSmartCell on the progress: > I'll continue the integration and then update when I have his new algorithm

> After further hand optimisation, 73,560 Gas. > > This will be the final gas spend for this contract, with the 'biased' array hash (which is vulnerable). I will move...

The same configurable key's public key should go into a contract with `verify() returns bool` function or `signingKeys() returns Keys` function hence tagging @fyang1024

> Furthermore since we now only issue attestations valid for an hour, there is no need to keep backward compatibility. When did this change came to be? This is too...

Is it this code? ./src/test/java/com/alphawallet/attestation/demo/UseAttestation.sol -> if so, move it to a includable library sol?

I believe this is a draft PR because Nick mentioned he would try to not include polyfill here (but in Negotiator library instead, or the website repo).

> 𝑦 mod 2 Nice! So @JamesSmartCell should be able to find 𝑣 value by just looking at the devcon issuer public key's last bit.

While PublicKeyInfo is still useful (in IdentifierAttestation I suppose), I'm [making the argument of not including it](https://github.com/TokenScript/attestation/pull/74#pullrequestreview-560616160) in SignedDevconTicket (the one that should be delivered by the end of 2020...

@jot2re decided to keep `PublicKeyInfo` optional instead of dropping it, so this issue can continue now.