Péter Tombor
Péter Tombor
@games647 I think this is Java related, and not Floodgate.
@games647 I've got some questions. As of now, (on branch `main`/https://github.com/games647/FastLogin/commit/9b04ea5c89e0b99bc273d28a1d9b0483c0a1b903), FastLogin allows Floodgate and Java players to be registered with the same name (without prefixes). However, the database contains...
I've decided to drop support for conflicting names alltogether. If a player is registered in Java, and logs in via Bedrock, they won't have access to auto login/register (they won't...
~~Note for myslef: https://github.com/games647/FastLogin/pull/709/commits/87b21fd7d01f22062cf24c9887b53e045c327c61 (and it's parents) have merge conflicts resolved with https://github.com/games647/FastLogin/commit/6beaf194ce93ef0ae21f7e71286717f15ab54c18. This branch is currently based on https://github.com/games647/FastLogin/commit/62d7320a6e3f37c6b1a0ef63456c29856e80c9d6, as I couldn't strat up a server with anything newer.~~...
This pull request is more or less ready for review. ~~I'll finish the remaining TODOs, run some test~~ (done), and probably do a rebase. Commits 1c63e70, 25e71e8, ae9772c, 24d552d, eab6ef9...
> Well there also the approach of doing [migrations](https://book.cakephp.org/migrations/3/en/index.html). This what I heard is normally used when doing schema changes. The pluign you provided uses PHP, and I don't think...
> I rather was talking about the concept of having change based migrations. Then I misunderstood you, I thought you were talking about the library. > I don't think we...
I've moved the ProtocolLib fix to https://github.com/games647/FastLogin/pull/876 so I won't have to rebase ProtocolLib related commits when working on the database. As long as the fix gets merged before the...
The migrator works, but the code is a mess in my opinion. I think that it'd be better to refactor the code, and make SQLStorage a kind of connection manager...
I have tested the migration from 7425df8 (branch main) to 1d0e089 (#709) on paper 1.19.2 with SQLite and MariaDB and encountered no issues with it. EDIT: I've found a bug.