Domoticz-deCONZ icon indicating copy to clipboard operation
Domoticz-deCONZ copied to clipboard

made link clickable

Open flopp999 opened this issue 4 years ago • 8 comments

You may try it before you release it

flopp999 avatar Dec 13 '20 16:12 flopp999

I have tested, It works but why the "&" ?

Smanar avatar Dec 13 '20 16:12 Smanar

I have tested, It works but why the "&" ?

I tried without & and then it get strange, if I remember correct :) But please try without & and see what happens, maybe I had something else wrong

flopp999 avatar Dec 13 '20 16:12 flopp999

It s removed automaticaly on my side (on windows). No change with or without it, what is your strange thing that happen on your side ? ^^

If you are not sure make the PR on beta, will have more time to test, as I have send the PR today I forced to stop modification soon (because for exemple the domoticz plugin manager)

Smanar avatar Dec 13 '20 17:12 Smanar

It didn't showed as a link. Will try again w/o &

flopp999 avatar Dec 13 '20 17:12 flopp999

I didn't get a space between my text and the link, if I didn't use &

flopp999 avatar Dec 13 '20 22:12 flopp999

I dont have space on my side without & (But making test on windows ATM) tmp7

Smanar avatar Dec 14 '20 15:12 Smanar

Aha OK, i have Done text in front of the link, I think that is the difference. Nice that you implanted it 😃

flopp999 avatar Dec 14 '20 16:12 flopp999

I have done nothing ^^, just copy/paste your code, it s for that I don't understand why it don't work on your side. Have just removed or not the "&", but it s removed on final code when the page is displayed

And it s not on the last official yet, I will put it in the beta, now it s too late, if I change the code again, it will trigger a new update.

Smanar avatar Dec 14 '20 16:12 Smanar