rn-components-kit icon indicating copy to clipboard operation
rn-components-kit copied to clipboard

[progress] Always use the green color for percent 100

Open noxmuse opened this issue 6 years ago • 5 comments

<Progress
  color={purple}
  percent={100}
  showInfo={false}
/>

image

noxmuse avatar Nov 16 '19 06:11 noxmuse

@wallevy purple should be a string.

SmallStoneSK avatar Nov 18 '19 01:11 SmallStoneSK

@SmallStoneSK I know, the `purple' is a variable name.

const purple = '#9025fc'

<Progress
  color={purple}
  percent={100}
  showInfo={false}
/>

noxmuse avatar Nov 18 '19 03:11 noxmuse

@wallevy Yeah, 100 means it has been completed and color green always represents success. So I always use green for percent 100.

SmallStoneSK avatar Nov 18 '19 04:11 SmallStoneSK

@SmallStoneSK Thank you, that's my misunderstanding, because I saw this success: task 100% completed (default green color) on the document. Sometimes maybe we need a different color for success.

noxmuse avatar Nov 18 '19 04:11 noxmuse

@wallevy Yeah, welcome PR~

SmallStoneSK avatar Nov 18 '19 08:11 SmallStoneSK