Slimmmo.github.io icon indicating copy to clipboard operation
Slimmmo.github.io copied to clipboard

Suits Marked as Urgent

Open alexarze opened this issue 8 years ago • 11 comments

Suits should not be marked as urgent since they are a gold purchase

alexarze avatar Apr 06 '16 02:04 alexarze

My intention with the exclamation mark was to just inform you that there is a better option, the fact that it's an exclamation mark wasn't supposed to indicate urgency. Perhaps that's a bad decision on my part, I'll look into ways of indicating better options other than the exclamation mark.

Thanks for the feedback!

Slimmmo avatar Apr 06 '16 02:04 Slimmmo

Alright. To me, it seems urgent (especially when the exclamation mark doesn't go away after viewing the notification from that tab). Also, it seems inconsistent because not all angel investor upgrades are marked unless they give a significant upgrade, even if you can afford them (hence a "better option")

alexarze avatar Apr 06 '16 02:04 alexarze

I've change them to pluses instead of exclamation marks, do you agree that it's better?

Slimmmo avatar Apr 06 '16 02:04 Slimmmo

I don't know. Personally (as a user), I don't see any point in having it there. If I'm using the calculator, chances are I'll learn about the suits sooner or later and duh a suit gives a bonus. At most I might put a notification that disappears as soon as you view that tab for the first time in your save state.

alexarze avatar Apr 06 '16 04:04 alexarze

By the way, I might want to let you know just how much I appreciate your calculator. I'm just playing devil's advocate so that it can get better (I design software, so I know that can be useful sometimes). So anyways, thank you SO much for taking the initiative in the AdCap community :)

alexarze avatar Apr 06 '16 04:04 alexarze

No problem, I appreciate the feedback so thank-you.

I didn't notice the end of your comment before I changed them to pluses but to reply to that I say that the point of them is to indicate some way of increasing your income, since not all upgrades or suits are actually increases in income since you lose some income in the loss of angels. Significance has nothing to do with it, the code is simply "will buying this increase my income? yes -> indicator : no -> no indicator". Unfortunately this has nothing to do with when you reset, which is next to impossible to get as input from a human player as it's completely dynamic, so the calculator may say something is worth buying for angels when it actually isn't when considered together with resetting.

The suits work in the same way in that it will only show an indicator if it's a better option than what you have, which may change as you progress (idk if it does). So if you're really min-maxing you would want to know if the green suit would give you more income than the blue suit even if it's just for a day.

Slimmmo avatar Apr 06 '16 05:04 Slimmmo

That makes sense. I just added a pull-request that adds the dismissal of that notification once the accordion has been opened, thus the notification has been "viewed". That should (hopefully) diminish the urgency of having a plus or exclamation mark in the header for that accordion, letting the user know that it's available, but not constantly nagging them about it.

alexarze avatar Apr 06 '16 06:04 alexarze

#45 --> Full solution

alexarze avatar Apr 15 '16 14:04 alexarze

Also the plus sign for suits appears on the event tab too, even though suits don't apply for events.

kazerniel avatar Apr 18 '16 10:04 kazerniel

@kazerniel I looked into that issue- it may be worthwhile opening a new issue for that because none of the events (presumably) will include suit bonuses. I tried a solution, but it will need a lot more than simply emptying the suits array because there are multiple processes that assume there will be suits there.

alexarze avatar Apr 18 '16 12:04 alexarze

I don't know what accordian this could be put in, but a really simple solution would be to have a checkbox with the option "Show urgent alerts" default would be true, if disabled no plus symbols would appear on any accordian. I don't suggest making another accordian for "Options" this already exists on the redesign, on the current site it would just make it too cluttered. This could also be expanded to be "Show urgent alerts for..." and you could toggle them for super badges, suits, and angel upgrades all seperately.

61352151511 avatar Aug 14 '16 20:08 61352151511