dough icon indicating copy to clipboard operation
dough copied to clipboard

Support 1.20.6

Open EpicPlayerA10 opened this issue 1 year ago • 4 comments

Changes

  • Added required adapters for 1.20.6 due to internals breaking changes
  • Restructured a bit PlayerHeadAdapters
  • Added paper-specific adapters too. This change will make dough future-proof on paper.
  • Added exclusions in pom.xml in module dough-protection because dough couldn't be compiled. This is because one of dependencies provided very old version of bukkit which broke compilation
  • In main pom.xml changed from spigot to paper to be able to use paper features in adapters

EpicPlayerA10 avatar May 29 '24 21:05 EpicPlayerA10

ItemUtils.damageItem needs an update as well, the unbreaking enchantment enum name is renamed.

We don't need to do this as from what i see dough is not updating minecraft version in the pom.xml: https://github.com/Slimefun/dough/blob/baf2d79f6209b928209721981df0487f17410ac1/pom.xml#L287-L292 And spigot already auto renames these fields for plugins that are built for older minecraft versions: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/legacy/FieldRename.java . So no error will be thrown.

EpicPlayerA10 avatar Jun 15 '24 17:06 EpicPlayerA10

This pr conflicts with #219.

mcchampions avatar Jul 10 '24 05:07 mcchampions

ItemUtils.damageItem needs an update as well, the unbreaking enchantment enum name is renamed.

We don't need to do this as from what i see dough is not updating minecraft version in the pom.xml:

https://github.com/Slimefun/dough/blob/baf2d79f6209b928209721981df0487f17410ac1/pom.xml#L287-L292

And spigot already auto renames these fields for plugins that are built for older minecraft versions: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/legacy/FieldRename.java . So no error will be thrown.

This does need to be updated as otherwise dough cannot compile if the consumer is compiling against 1.20.5+. The suggested fix is to refactor it to use the bukkit Registry.ENCHANTMENT api and grab it via the minecraft namespaced key.

md5sha256 avatar Aug 11 '24 10:08 md5sha256

Done

EpicPlayerA10 avatar Aug 11 '24 10:08 EpicPlayerA10