Slimefun4
Slimefun4 copied to clipboard
Piglin Barter Drops are Biased
โ Checklist
- [x] I am using the official english version of Slimefun and did not modify the jar.
- [x] I downloaded the official version from the new build site Blob Builds.
- [x] I am using an up to date "DEV" (not "RC") version of Slimefun.
- [x] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- [x] I searched for similar open issues and could not find an existing bug report on this.
๐ Description
The piglin barter drop recipe type uses a hashset and iterates over it when generating the custom drop, the hash set, after its done being modified (post finalized event) will have a deterministic order for the runtime of the server.
Because of this, the items at the beginning of the iteration order have a bias towards being dropped.
๐ Reproduction Steps
Look at the code
๐ก Expected Behavior
Drops would be properly randomized always
๐ท Screenshots / Videos
No response
๐ Server Log
No response
๐ /error-reports/ folder
No response
๐ป Server Software
Spigot
๐ฎ Minecraft Version
1.20.x
โญ Slimefun version
๐งญ Other plugins
No response