Replace copper ingot with copper from original Minecraft.

[Outfit8TSB]

Description

on 1.17, the copper was added, however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining. this commit replaces Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft.

all users making a new addon should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT).

Proposed changes

Remove SlimefunItems.COPPER_INGOT and replace with new ItemStack(Material.COPPER_INGOT)

Related Issues (if applicable)

Checklist

• [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
• [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
• [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
• [ ] I followed the existing code standards and didn't mess up the formatting.
• [ ] I did my best to add documentation to any public classes or methods I added.
• [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
• [ ] I added sufficient Unit Tests to cover my code.

[github-actions[bot]]

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention	Label
feature/**	🎈 Feature
fix/**	✨ Fix
chore/**	🧹 Chores
api/**	🔧 API
performance/**	💡 Performance Optimization
compatibility/**	🤝 Compatibility

---

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

[ybw0014]

I think this would never be considered before the recipe system rewrite (support interchangeable ingredients), but we can see what admins think.

[Boomer-1]

agreed ybw. there's too much impact that wasn't considered as it will affect every addon and break them all, along with every players base, sorting systems, network systems, etc., much more care has to be put into this before it would be rolled out

[Outfit8TSB]

D'oh, i didnt reailze that. 😵 But you should consider that Copper was Added in 1.17. but the copper from slimefun was really like existed in 1.17~1.21. Why do you even want to keep it? They are @Deprecated. It Must be replaced with new Itemstack(Material.COPPER_INGOT). If Slimefun copper is there, whats the point for Copper in Minecraft? For that, i think the old SlimefunItems.COPPER_INGOT Should be removed, And Must be replaced to new ItemStack(Material.COPPER_INGOT).

[gphg]

Let's ship it on Slimefun 5!

[Outfit8TSB]

Let's ship it on Slimefun 5!

shush! no saying about slimefun 5. this is slimefun 4.