Slimefun4
Slimefun4 copied to clipboard
Prevent number key usage in GPS-related GUIs
Description
Resolves #4260
Proposed changes
- Added isNumberKey() method to ClickAction class to detect number key usage
- Modified MenuListener to pass InventoryClickEvent to ClickAction constructor
- Added special handlers to GPS Control Panel, Waypoint Panel, and GEO Scanner GUIs
Related Issues (if applicable)
Resolves #4260
Checklist
- [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
- [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
- [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
- [x] I followed the existing code standards and didn't mess up the formatting.
- [x] I did my best to add documentation to any public classes or methods I added.
- [ ] I have added
NonnullandNullableannotations to my methods to indicate their behaviour for null values - [ ] I added sufficient Unit Tests to cover my code.
Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ
| Branch naming convention | Label |
|---|---|
feature/** |
๐ Feature |
fix/** |
โจ Fix |
chore/** |
๐งน Chores |
api/** |
๐ง API |
performance/** |
๐ก Performance Optimization |
compatibility/** |
๐ค Compatibility |
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐
Slimefun preview build
A Slimefun preview build is available for testing! Commit: c850d4e6
https://preview-builds.walshy.dev/download/Slimefun/4297/c850d4e6
Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!