Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Prevent number key usage in GPS-related GUIs

Open RaphaelFakhri opened this issue 10 months ago โ€ข 2 comments

Description

Resolves #4260

Proposed changes

  1. Added isNumberKey() method to ClickAction class to detect number key usage
  2. Modified MenuListener to pass InventoryClickEvent to ClickAction constructor
  3. Added special handlers to GPS Control Panel, Waypoint Panel, and GEO Scanner GUIs

Related Issues (if applicable)

Resolves #4260

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

RaphaelFakhri avatar Mar 05 '25 19:03 RaphaelFakhri

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar Mar 05 '25 19:03 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: c850d4e6

https://preview-builds.walshy.dev/download/Slimefun/4297/c850d4e6

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Mar 07 '25 09:03 github-actions[bot]