The data displayed by placeholder and /sf stats is different
❗ Checklist
- [X] I am using the official english version of Slimefun and did not modify the jar.
- [X] I downloaded the official version from the new build site Blob Builds.
- [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
- [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- [X] I searched for similar open issues and could not find an existing bug report on this.
📍 Description
The percentage shown by the placeholder and /sf stats is different.
I tested with a player who just opened 1 slimefun item, the placeholder shows his research progress is 0.32% while the /sf stats show 0.35%
possible causes
There are some slimefun items that I disabled.
The data displayed by the placeholder %slimefun_researches_percentage_researches_unlocked% displays data from all slimefun items (including the disabled ones)
while the /sf stats displays data from all slimefun items (except the disabled ones)
📑 Reproduction Steps
- Unlock some slimefun items
- Check placeholder
%slimefun_researches_percentage_researches_unlocked% - Check
/sf stats(Research progress)
The percentages displayed will be different
💡 Expected Behavior
The percentage displayed should be the same
📷 Screenshots / Videos
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Paper
🎮 Minecraft Version
1.20.x
⭐ Slimefun version
Slimefun vDev - 1157
🧭 Other plugins
No response
hm
It looks like the discrepancy is the researches_percentage_researches_unlocked conditional counts all researches, including those with no enabled items (e.g., disabled ones), which is not how /sf stats works. I'll take a look
Created a PR for it