Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Fix/machine inventory drop

Open Intybyte opened this issue 1 year ago • 2 comments

Proposed changes

Create a class extending SimpleBlockBreakHandler that handles inventories and MachineProcesoors (MachineBlockBreakHandler). If the MachineProcessor is of CraftingOperation type and the process isn't completed, then the ingredients will be dropped.

Related Issues (if applicable)

Resolves #4268

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

Intybyte avatar Dec 12 '24 14:12 Intybyte

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Dec 12 '24 14:12 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 9d621cf0

https://preview-builds.walshy.dev/download/Slimefun/4271/9d621cf0

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Dec 12 '24 14:12 github-actions[bot]