Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

feat: onExplode customization on EnergyNetProvider

Open ybw0014 opened this issue 1 year ago โ€ข 2 comments

Description

Currently, the behavior of a block that should explode is hard-coded, which is becoming lava and creating a small explosion. This PR would allow addon developers to use willExplode with onExplode to implement some tremendous ideas.

Proposed changes

Added onExplode(Location) to EnergyNetProvider, default to the current explosion behavior. Changed EnergyNet to use onExplode from provider.

Related Issues (if applicable)

Just an idea came after I saw a chat.

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

ybw0014 avatar Nov 20 '24 19:11 ybw0014

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar Nov 20 '24 19:11 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: e93eaa71

https://preview-builds.walshy.dev/download/Slimefun/4267/e93eaa71

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Nov 20 '24 19:11 github-actions[bot]