Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Feature/flint and steal unbreaking

Open Intybyte opened this issue 1 year ago • 2 comments

Description

Make the Automatic Ignition chamber respect the level of the Unbreaking enchantment on the tool selected for durability loss (thus, an Unbreaking 3 Flint and Steel would last 4 times as long on average).

Proposed changes

Refactor the code releated to damaging the flint and steal into a damageFlintAndSteel method that uses vanilla MC unbreaking calculation to determine when to damage the flint and steal

Related Issues (if applicable)

Suggestion 2429 #approved

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

Intybyte avatar Sep 26 '24 11:09 Intybyte

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Sep 26 '24 11:09 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 5a823160

https://preview-builds.walshy.dev/download/Slimefun/4247/5a823160

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Sep 26 '24 11:09 github-actions[bot]