Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard
verified publisher icon Slimefun

Add powder snow block to the list of blocks that the Explosive Shovel can break

Open RenanMsV opened this issue 1 year ago • 4 comments

Description

Hello, I was playing the minecraft 1.20.4 and noticed that the Explosive Shovel can't break powder snow blocks. I believe they should be able to break this block.

Proposed changes

Add powder snow block to the list of blocks that the Explosive Shovel can break.

Related Issues (if applicable)

An issue is that this block came in minecraft 1.17, so most likely 1.16 would not be compatible. This might not be an issue but this block drops nothing, since it can only be collected with buckets like a liquid.

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [x] I added sufficient Unit Tests to cover my code.

RenanMsV avatar Sep 12 '24 00:09 RenanMsV

Your Pull Request was automatically labelled as: "🧹 Chores" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Sep 12 '24 00:09 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 95b70e88

https://preview-builds.walshy.dev/download/Slimefun/4241/95b70e88

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Sep 12 '24 00:09 github-actions[bot]

with 1.21, support will be dropped for 1.16.x and 1.17, so it might be worth waiting to merge until after the 1.21 release if it's approved.

Boomer-1 avatar Sep 12 '24 00:09 Boomer-1

to make it compatible right now, u need to mark it as not required, like the soul_soil field.

ybw0014 avatar Sep 13 '24 16:09 ybw0014