Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Add events to Lumber Axe & Woodcutter Android

Open JustAHuman-xD opened this issue 1 year ago • 5 comments

Description

Due to the lack of events with the lumber axe & woodcutter androids there are currently problems with the "SurperiorSkyblock2" plugin. (See issue referenced)

Proposed changes

  • Added AndroidBlockBreakEvent
    • Meant to be a generic event whenever any android breaks a block
    • Based on the old AndroidMineEvent
  • Rewrote AndroidMineEvent
    • Now extends AndroidBlockBreakEvent and all duplicate functionality has been removed
  • Added AndroidWoodcutEvent
    • Not sold on the name but is what it is atm
    • Called whenever a Woodcutter android tries to break a log
  • Added a BlockStorage check to the Woodcutter Android, I'm concerned that there wasn't one already lol
  • Changed the Lumber Axe to call a BlockBreakEvent for every log it breaks & respect the event's dropItems field.

Related Issues (if applicable)

https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/2198

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

JustAHuman-xD avatar Aug 30 '24 16:08 JustAHuman-xD

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Aug 30 '24 16:08 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 82fbbbf4

https://preview-builds.walshy.dev/download/Slimefun/4228/82fbbbf4

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Aug 30 '24 16:08 github-actions[bot]

Ok wow I meant to edit my comment but sure

Alessio-Colombo avatar Sep 06 '24 12:09 Alessio-Colombo

I did test it a bit on my own and it worked as expected but another test would be good I agree

JustAHuman-xD avatar Sep 06 '24 12:09 JustAHuman-xD

Adding an event for vein breaking tools would helpful, but probably put of the scope of this PR

Intybyte avatar Nov 28 '24 14:11 Intybyte