Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Fix errors in SlimefunUtils

Open mcchampions opened this issue 1 year ago • 1 comments

Description

Fix #4212

This issue explains why to change.

or move equalsItemMeta check to if (id != null && id.equals(possibleItemId)) { ?

Proposed changes

  • remove equalsItemMeta check
  • rename var

Related Issues (if applicable)

#4212

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

mcchampions avatar Jun 28 '24 00:06 mcchampions

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Jun 28 '24 00:06 github-actions[bot]