Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Fix ChargingBench

Open Intybyte opened this issue 1 year ago โ€ข 3 comments

Description

Making ChargingBench rechargeable only ItemStacks with 1 items

Proposed changes

By adding this feature addon makers can make heir own Rechargeable any item they want and not be limited to tools

Related Issues (if applicable)

Resolves #4183

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

Intybyte avatar May 03 '24 17:05 Intybyte

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar May 03 '24 17:05 github-actions[bot]

I did not want to dismiss the review aaaa

JustAHuman-xD avatar May 30 '24 19:05 JustAHuman-xD

Slimefun preview build

A Slimefun preview build is available for testing! Commit: cf0a9e8e

https://preview-builds.walshy.dev/download/Slimefun/4184/cf0a9e8e

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar May 30 '24 19:05 github-actions[bot]